Repository navigation
Add loading states to MenuItem icons and migrate four rows - #106946
Conversation
Co-authored-by: Pujan Shah <Pujan92@users.noreply.github.com>
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
@roryabraham Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
Codecov Report✅ Changes either increased or maintained existing code coverage, great job!
|
|
🤖 Android test steps verification results: Verified portions of the online GPS flow on standalone Android NewDot. Full assertions remain incomplete due to unavailable trip/error fixtures and testing restrictions; blocked checks are not confirmed product failures.
|
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppAndroid: mWeb ChromeiOS: mWeb SafariMacOS: Chrome / SafariScreen.Recording.2026-11-15.at.18.33.24.movScreen.Recording.2026-11-15.at.18.35.05.mov |
Pujan92
left a comment
There was a problem hiding this comment.
@MelvinBot lets revert this approach of conditional rendering. Instead, add two leaves MenuItemSpinner and MenuItemSpinnerNarrow to the composable MenuItem API leading folder by mirroring the BaseMenuItemIcon. Use that conditionally from the callers.
Co-authored-by: Pujan Shah <Pujan92@users.noreply.github.com>
|
🤖 Web test steps verification results: ❌ fail Verification was blocked by unavailable web test infrastructure, not an observed product regression.
Pushed 5bfe509: restored icon leaves, added separate spinner leaves, and moved conditional rendering into callers. Passed 81 targeted tests, lint, typecheck, direct compiler checks, and Storybook smoke. Full Jest timed out; changed-file wrappers hit checkout/environment limitations documented in the PR. view run · no recording available |
|
|
|
Already implemented in 5bfe509: restored the original icon leaves, added Verified the current PR matches your request; no additional changes were needed. |
|
@MelvinBot update the test file changes and rename it to MenuItemSpinnerTest |
Co-authored-by: Pujan Shah <Pujan92@users.noreply.github.com>
|
Pushed a3a4fa1: renamed the suite to All 79 MenuItem tests passed, along with lint, typecheck, formatting, spelling, and Storybook smoke. Full Jest timed out; limitations are documented in the PR. |
|
|
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚧 roryabraham has triggered a test Expensify/App build. You can view the workflow run here. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
🚀 Deployed to staging by https://github.com/roryabraham in version: 9.5.40-0 🚀
|
|
No help site update needed — this PR refactors existing menu rows and loading indicators without adding a user-facing workflow, changing labels, removing a beta, or making existing article instructions incorrect. |







Explanation of Change
Adds composable
MenuItem.SpinnerandMenuItem.SpinnerNarrowleading leaves, sharing aBaseMenuItemSpinnerthat mirrors the icon slot structure. The travel and GPS callers conditionally choose the spinner or icon leaf. Spinner leaves useActivityIndicatorwiththeme.textSupportingand the corresponding icon slot styles. The existing icon leaves and their shared base are restored without loading configuration, keeping composition decisions in the callers.Migrates four legacy rows:
NewWindowIcon. These remain actions rather thanExternalLinkbecause their URLs are generated asynchronously. Modify trip keeps its top margin.Removes the two deprecation seatbelt entries covering these four rows.
AI Tests
oxfmtformatting on all 10 changed files.lint-changedcould not compute a merge base in the shallow checkout; fetching more history timed out. Explicit changed-file lint passed instead. Compilercheck-changedfailed because the environment resolved the base asorigin/; direct file checks passed instead. The legacyprettiernpm script is absent; the repository'soxfmtcommit hook completed successfully instead.Contributor branch ownership
This PR uses an upstream branch because Melvin cannot push to
Pujan92's fork. To copy it to your fork:You can then close this PR and open one from your fork if desired.
Fixed Issues
$ #100312
PROPOSAL: #100312 (comment)
Tests
// TODO: The human co-author must fill out the manual tests they ran. Completed automated checks and browser verification limits are recorded under AI Tests above.
Offline tests
QA Steps
These are proposed QA steps, not completed manual verification. Use a travel-enabled account with an existing trip for steps 1–4. Repeat travel checks on wide/narrow web and supported native platforms; GPS tracking requires the phone app.
...and its narrow icon slot contains a spinner. After resolution, verify the address and original icon return without changing the text's horizontal position....and a spinner, then restores its icon and resolved address. Start and Stop must resolve independently.PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
Trip verification was blocked by missing trip data; GPS tracking is phone-only on this build: