Skip to content

Add loading states to MenuItem icons and migrate four rows - #106946

Merged
roryabraham merged 3 commits into
mainfrom
claude-menuItemLoadingIcons
Nov 16, 2026
Merged

roryabraham merged 3 commits into
mainfrom
claude-menuItemLoadingIcons

Conversation

@MelvinBot

@MelvinBot MelvinBot commented Nov 15, 2026 •

Copy link
Copy Markdown
Contributor

Explanation of Change

Adds composable MenuItem.Spinner and MenuItem.SpinnerNarrow leading leaves, sharing a BaseMenuItemSpinner that mirrors the icon slot structure. The travel and GPS callers conditionally choose the spinner or icon leaf. Spinner leaves use ActivityIndicator with theme.textSupporting and the corresponding icon slot styles. The existing icon leaves and their shared base are restored without loading configuration, keeping composition decisions in the callers.

Migrates four legacy rows:

  • Modify trip / Trip support: composed button rows with unchanged Sentry labels, authenticated actions, each action's loading/offline disabling, and trailing NewWindowIcon. These remain actions rather than ExternalLink because their URLs are generated asynchronously. Modify trip keeps its top margin.
  • GPS Start / Stop: noninteractive rows with vertical padding, narrow loading icons, and field labels above the existing addresses/ellipses. Existing waypoint Sentry-label constants are attached to the rows, which previously had no label prop.

Removes the two deprecation seatbelt entries covering these four rows.

AI Tests

  • Passed after the spinner-test review update: 79 tests across 8 MenuItem suites, including 4 spinner-focused cases covering both leaf widths, spinner color/slot styles, glyph restoration, and unchanged row actions. Renamed the test suite to MenuItemSpinnerTest.tsx. Accessibility and other MenuItem regression suites passed.
  • For this tests-only update, full lint, explicit changed-file lint, typecheck, explicit changed-file spell check, Storybook smoke, and the commit hook's formatting passed. Full Jest again timed out after 180 seconds with no failing suite reported. Changed-file lint/spell discovery remained blocked by the shallow checkout's missing merge base; explicit file checks passed. The full staged PR diff was reviewed against GitHub's verified merge base with no standards violations. No runtime code changed, so live web verification was not repeated.
  • Passed: full lint, explicit changed-file lint, typecheck, spell check, direct React Compiler checks for the leading leaves and both callers, Storybook smoke, and the commit hook's oxfmt formatting on all 10 changed files.
  • Inline review of the complete staged PR diff returned no standards violations; accessibility and correctness were also reviewed.
  • Full Jest was attempted with two workers but timed out after 180 seconds; no failing suite was reported before timeout. The targeted suites above completed separately.
  • lint-changed could not compute a merge base in the shallow checkout; fetching more history timed out. Explicit changed-file lint passed instead. Compiler check-changed failed because the environment resolved the base as origin/; direct file checks passed instead. The legacy prettier npm script is absent; the repository's oxfmt commit hook completed successfully instead.
  • Web verification was blocked by unavailable test infrastructure: the pinned page had no rendered UI and the suspended app session remained unavailable after a retry. No live spinner, text-position, offline, or GPS-row behavior is claimed as verified. Native, offline, and screen-reader QA remain outstanding.

Web verification blocked by unavailable app session

Contributor branch ownership

This PR uses an upstream branch because Melvin cannot push to Pujan92's fork. To copy it to your fork:

git remote add upstream https://github.com/Expensify/App.git
git fetch upstream claude-menuItemLoadingIcons
git checkout -b claude-menuItemLoadingIcons upstream/claude-menuItemLoadingIcons
git push -u origin claude-menuItemLoadingIcons

You can then close this PR and open one from your fork if desired.

Fixed Issues

$ #100312
PROPOSAL: #100312 (comment)

Tests

// TODO: The human co-author must fill out the manual tests they ran. Completed automated checks and browser verification limits are recorded under AI Tests above.

  • Verify that no errors appear in the JS console

Offline tests

  1. Load an existing trip's details, disconnect the network, and verify both Modify trip and Trip support are disabled and cannot initiate link generation. Reconnect and verify they become available again.
  2. On a phone, inspect a GPS draft while address lookup is unavailable. Verify unresolved addresses retain their existing ellipsis/spinner behavior without making Start/Stop rows interactive. Reconnect and confirm resolved addresses replace ellipses and restore the icons.

QA Steps

These are proposed QA steps, not completed manual verification. Use a travel-enabled account with an existing trip for steps 1–4. Repeat travel checks on wide/narrow web and supported native platforms; GPS tracking requires the phone app.

  1. Open an existing trip's details. Verify Modify trip and Trip support retain their titles, left icons, and right new-window indicators. Confirm Modify trip retains its top spacing and both rows match the existing alignment/padding.
  2. Press Modify trip. While its link is being generated (use a controlled slow response if needed), verify only that row replaces its leading glyph with the supporting-color spinner, keeps the same text position, and ignores repeated presses. Verify the generated destination opens and the glyph returns when the request settles. Repeat for Trip support.
  3. Exercise a failed link-generation response using a test fixture. Confirm the loading state clears when the promise settles and the row can be retried, retaining existing error handling. Verify loading one action does not unexpectedly disable the other action.
  4. Repeat the offline steps above. Tab to each enabled travel action and activate it from the keyboard. Verify the accessible name includes the title and the existing opens-in-new-tab announcement. Check signed-out access follows the existing authentication gate instead of opening the generated destination.
  5. On a phone, start a GPS distance expense. While the start address resolves, verify Start shows its label above ... and its narrow icon slot contains a spinner. After resolution, verify the address and original icon return without changing the text's horizontal position.
  6. While GPS tracking is active, verify Stop retains the tracking-distance text and location icon. Stop the trip; while the end address resolves, verify Stop shows ... and a spinner, then restores its icon and resolved address. Start and Stop must resolve independently.
  7. Verify GPS Start/Stop have no row press action, chevron, disabled dimming, or keyboard button behavior. Confirm portrait and landscape layouts retain the existing vertical padding and scroll behavior.
  8. Check an unrelated menu row using each icon leaf; its normal glyph, hover/pressed colors, and spacing must remain unchanged. Check no JS console errors appear.
  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I verified any copy / text that was added to the app is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If the PR adds or modifies the UI:
    • I asked an AI agent to review the changes for accessibility issues and addressed its findings.
    • I tested with a screen reader (VoiceOver on macOS) and verified all new/changed elements are reachable with a logical focus order.
    • I verified all new/changed elements have meaningful accessible names and roles.
    • I verified state changes are announced (e.g. checked/unchecked, expanded/collapsed, selected).
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari

Trip verification was blocked by missing trip data; GPS tracking is phone-only on this build:

No trip fixture available for loading icon verification GPS tracking requires the phone app

Co-authored-by: Pujan Shah <Pujan92@users.noreply.github.com>
@MelvinBot
MelvinBot requested review from a team as code owners November 15, 2026 12:30
@melvin-bot melvin-bot Bot added Melvin-Test-Android Melvin-Test-Web Triggers Melvin to run the testing steps of the PR on web labels Nov 15, 2026
@expensify-chore-bot
expensify-chore-bot Bot requested review from Pujan92 and garrettmknight and removed request for a team and garrettmknight November 15, 2026 12:30
@expensify-chore-bot

Copy link
Copy Markdown

@Pujan92 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@expensify-chore-bot
expensify-chore-bot Bot removed the request for review from a team November 15, 2026 12:30
@MelvinBot
MelvinBot requested a review from a team November 15, 2026 12:30
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 15, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-15T12:32:24.589539Z 522714e PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@expensify-chore-bot

Copy link
Copy Markdown

@roryabraham Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@MelvinBot

MelvinBot commented Nov 15, 2026 •

Copy link
Copy Markdown
Contributor Author

🤖 Web test steps verification results: ❌ fail

Verification was blocked: no existing-trip fixture was found, and available tools cannot create one. No product defect was established; phone-only GPS checks remain unverified.
Signed-in Web account showing available actions without a trip fixture

Step Status
Tests: No JS console errorsConsole inspection is unavailable through supported Web tooling.
❌
Offline 1: Travel actions disable and recoverBlocked by missing trip data and unavailable offline simulation.
❌
Offline 2: GPS address lookup recoveryPhone-only behavior; unavailable on Web.
❌
QA 1: Travel titles, icons, spacing, and responsive layoutNo existing trip was found in the signed-in account; wide/narrow layouts remain unverified.
Signed-in Web account showing available actions without a trip fixture
❌
QA 2: Loading spinners and action completionTravel actions were unavailable; spinner color, stable text position, repeated-press prevention, destination opening, and icon restoration remain unverified.
❌
QA 3: Failure recovery and independent loadingNo trip or failed-link-generation fixture was available.
❌
QA 4: Offline, keyboard, accessibility, and authenticationTravel actions were unavailable. Offline simulation is unsupported; signed-out testing was not attempted because signing out is prohibited.
❌
QA 5: GPS Start resolutionPhone-only behavior; unavailable on Web.
❌
QA 6: GPS Stop and independent resolutionPhone-only behavior; unavailable on Web.
❌
QA 7: GPS noninteractive rows and orientationPhone-only behavior; unavailable on Web.
❌
QA 8: Unrelated icon-leaf regression checksSuitable rows were not identified; glyph, interaction colors, spacing, and console checks remain unverified.
❌

view run · view recording

@codecov

codecov Bot commented Nov 15, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines Coverage Δ
src/components/MenuItem/index.ts 100.00% <ø> (ø)
...onents/MenuItem/leaves/leading/MenuItemSpinner.tsx 100.00% <100.00%> (ø)
.../MenuItem/leaves/leading/MenuItemSpinnerNarrow.tsx 100.00% <100.00%> (ø)
...nuItem/leaves/leading/base/BaseMenuItemSpinner.tsx 100.00% <100.00%> (ø)
...step/IOURequestStepDistanceGPS/Waypoints/index.tsx 0.00% <0.00%> (ø)
src/pages/Travel/DynamicTripDetailsPage.tsx 0.00% <0.00%> (ø)
... and 59 files with indirect coverage changes

@MelvinBot

MelvinBot commented Nov 15, 2026 •

Copy link
Copy Markdown
Contributor Author

🤖 Android test steps verification results: ⚠️ partial

Verified portions of the online GPS flow on standalone Android NewDot. Full assertions remain incomplete due to unavailable trip/error fixtures and testing restrictions; blocked checks are not confirmed product failures.
Portrait GPS address rows without chevrons, above separate Resume and Save buttons

Step Status
Tests: No JS console errorsBlocked: console inspection was denied. No error overlay appeared, but a clean console remains unverified.
❌
Offline 1: Travel actions disable and recoverBlocked: no existing-trip fixture was available, and connectivity changes were denied.
❌
Offline 2: GPS address lookup and reconnect recoveryBlocked: connectivity changes were denied, preventing offline/address-lookup testing.
❌
QA 1: Travel titles, icons, indicators, and spacingBlocked: existing trip details were unavailable in the test account.
❌
QA 2: Travel loading and action completionBlocked: travel actions were unavailable. Spinners, repeated-press prevention, destination opening, and glyph restoration remain unverified.
❌
QA 3: Failed link generation and independent loadingBlocked: neither a trip nor a controlled failure fixture was available.
❌
QA 4: Offline, keyboard, accessibility, and authenticationBlocked by unavailable travel/offline fixtures. The signed-in session was preserved because re-authentication is unsupported.
❌
QA 5: GPS Start loading and resolutionObserved Start change from ellipsis to a resolved address with its original glyph. Spinner geometry and unchanged horizontal text position remain unverified.
Active GPS tracking with resolved Start address and original leading glyph
❌
QA 6: GPS Stop and independent resolutionStart resolved while Stop retained “Tracking distance...” and its location icon. Both addresses resolved after stopping; the brief Stop ellipsis/spinner transition was not captured.
Resolved Start address alongside active Stop tracking text and location icon
Stopped GPS draft with both addresses resolved
❌
QA 7: GPS noninteractive rows and orientationAccessibility snapshots exposed address rows as groups, separate from buttons; portrait evidence shows no chevrons. Press behavior, keyboard behavior, dimming, landscape layout, and scrolling remain unverified.
Portrait GPS address rows without chevrons, above separate Resume and Save buttons
❌
QA 8: Unrelated icon-leaf regression checksRepresentative unrelated rows were not established. Interaction colors, spacing, and console errors remain unverified.
❌

view run · view recording

@Pujan92

Pujan92 commented Nov 15, 2026 •

Copy link
Copy Markdown
Contributor

Reviewer Checklist

  • I have verified the author checklist is complete (all boxes are checked off).
  • I verified the correct issue is linked in the ### Fixed Issues section above
  • I verified testing steps are clear and they cover the changes made in this PR
    • I verified the steps for local testing are in the Tests section
    • I verified the steps for Staging and/or Production testing are in the QA steps section
    • I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I checked that screenshots or videos are included for tests on all platforms
  • I included screenshots or videos for tests on all platforms
  • I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
  • I verified tests pass on all platforms & I tested again on:
    • Android: HybridApp
    • Android: mWeb Chrome
    • iOS: HybridApp
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
  • I verified proper code patterns were followed (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I verified that this PR follows the guidelines as stated in the Review Guidelines
  • I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
  • If a new component is created I verified that:
    • A similar component doesn't exist in the codebase
    • All props are defined accurately and each prop has a /** comment above it */
    • The file is named correctly
    • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
    • The only data being stored in the state is data necessary for rendering and nothing else
    • For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
    • Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
    • All JSX used for rendering exists in the render method
    • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
  • I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp
Android: mWeb Chrome
iOS: HybridApp Simulator Screenshot - iPhone 15 Pro - 2026-11-16 at 18 18 43
iOS: mWeb Safari
MacOS: Chrome / Safari
Screen.Recording.2026-11-15.at.18.33.24.mov
Screen.Recording.2026-11-15.at.18.35.05.mov

@Pujan92 Pujan92 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Pujan92 Pujan92 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MelvinBot lets revert this approach of conditional rendering. Instead, add two leaves MenuItemSpinner and MenuItemSpinnerNarrow to the composable MenuItem API leading folder by mirroring the BaseMenuItemIcon. Use that conditionally from the callers.

Co-authored-by: Pujan Shah <Pujan92@users.noreply.github.com>
@MelvinBot

MelvinBot commented Nov 16, 2026 •

Copy link
Copy Markdown
Contributor Author

🤖 Web test steps verification results: ❌ fail

Verification was blocked by unavailable web test infrastructure, not an observed product regression.
Web verification blocked by unavailable app session

Step Status
Trip icons, alignment, spinners, and restorationNo rendered UI was available.
Web verification blocked by unavailable app session
❌
Unrelated menu icons and interactionBlocked by unavailable web UI.
❌
GPS rowsPhone-only behavior; not verified on web.
❌

Pushed 5bfe509: restored icon leaves, added separate spinner leaves, and moved conditional rendering into callers.

Passed 81 targeted tests, lint, typecheck, direct compiler checks, and Storybook smoke. Full Jest timed out; changed-file wrappers hit checkout/environment limitations documented in the PR.


view run · no recording available

@MelvinBot

Copy link
Copy Markdown
Contributor Author

⚠️ Something went wrong. This may be a transient issue. Try again. If it persists, check status.openai.com.

Run details

@MelvinBot

Copy link
Copy Markdown
Contributor Author

Already implemented in 5bfe509: restored the original icon leaves, added MenuItemSpinner and MenuItemSpinnerNarrow with a shared base mirroring the icon structure, and moved spinner/icon selection into the travel and GPS callers.

Verified the current PR matches your request; no additional changes were needed.


view run

@Pujan92

Pujan92 commented Nov 16, 2026

Copy link
Copy Markdown
Contributor

@MelvinBot update the test file changes and rename it to MenuItemSpinnerTest

Co-authored-by: Pujan Shah <Pujan92@users.noreply.github.com>
@MelvinBot

Copy link
Copy Markdown
Contributor Author

Pushed a3a4fa1: renamed the suite to MenuItemSpinnerTest.tsx and updated it around spinner leaves, retaining icon restoration and row-action coverage.

All 79 MenuItem tests passed, along with lint, typecheck, formatting, spelling, and Storybook smoke. Full Jest timed out; limitations are documented in the PR.


view run

@MelvinBot

Copy link
Copy Markdown
Contributor Author

⚠️ Something went wrong. This may be a transient issue. Try again. If it persists, check status.openai.com.

Run details

@roryabraham
roryabraham merged commit 70b3282 into main Nov 16, 2026
37 of 38 checks passed
@roryabraham
roryabraham deleted the claude-menuItemLoadingIcons branch November 16, 2026 18:56
@OSBotify

Copy link
Copy Markdown
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@github-actions

Copy link
Copy Markdown
Contributor

🚧 roryabraham has triggered a test Expensify/App build. You can view the workflow run here.

@github-actions

Copy link
Copy Markdown
Contributor

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by https://github.com/roryabraham in version: 9.5.40-0 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@MelvinBot

Copy link
Copy Markdown
Contributor Author

No help site update needed — this PR refactors existing menu rows and loading indicators without adding a user-facing workflow, changing labels, removing a beta, or making existing article instructions incorrect.


view run

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Melvin-Test-Android Melvin-Test-Web Triggers Melvin to run the testing steps of the PR on web

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants